[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/dockerfile-mode 35d10860d9 039/104: Fix inability to build
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/dockerfile-mode 35d10860d9 039/104: Fix inability to build images on Windows. |
Date: |
Sat, 29 Jan 2022 07:58:30 -0500 (EST) |
branch: elpa/dockerfile-mode
commit 35d10860d97e5d6ef8cf91bca3d56d4ee7f78cde
Author: Jacob MacDonald <jaccarmac@gmail.com>
Commit: Jacob MacDonald <jaccarmac@gmail.com>
Fix inability to build images on Windows.
When `dockerfile-use-sudo` was set to `nil`, the shell command for
building an image would start with a space, which had no effect on a
Linux system, but broke the ability to build on Windows. The error
message ("docker is not a docker command") seemed to indicate that a
space in front of a command causes it to double in some way, but I am
unable to duplicate a similar error in CMD, PowerShell, or Docker
Toolbox's Bash, with our without quotation marks around the command,
i.e. " docker".
Nevertheless, moving the space from the beginning of the base string to
the end of the piece inserted when `dockerfile-use-sudo` is non-`nil`
fixes the problem.
This fix does not address the problem of initializing the proper
environment variables. Emacs needs to inherit the settings suggested by
`docker-machine env` if the `docker` command is to work.
---
dockerfile-mode.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dockerfile-mode.el b/dockerfile-mode.el
index b992b81957..c83820e11e 100644
--- a/dockerfile-mode.el
+++ b/dockerfile-mode.el
@@ -90,7 +90,7 @@
(save-buffer)
(if (stringp image-name)
(async-shell-command
- (format "%s docker build -t %s -f \"%s\" \"%s\"" (if
dockerfile-use-sudo "sudo" "") image-name (buffer-file-name)
(file-name-directory (buffer-file-name)))
+ (format "%sdocker build -t %s -f \"%s\" \"%s\"" (if dockerfile-use-sudo
"sudo " "") image-name (buffer-file-name) (file-name-directory
(buffer-file-name)))
"*docker-build-output*")
(print "docker-image-name must be a string, consider surrounding it with
double quotes")))
- [nongnu] branch elpa/dockerfile-mode created (now 5db94549ce), ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 58179938b2 004/104: Only recognize Dockerfile keywords at beginning of the line, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 922845c229 002/104: Added dockerfile-mode.el, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 7f92c17b99 006/104: Option to use sudo when invoking docker builder, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 8771eb1d9a 022/104: Use async-shell-command instead of shell-command, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 6ed974d462 014/104: Autoload docker mode for Dockerfiles., ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode d1e9754285 037/104: Fix build failure when path of Dockerfile contains spaces., ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode e20c7e587a 025/104: Correctly set require-final-newline, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 35d10860d9 039/104: Fix inability to build images on Windows.,
ELPA Syncer <=
- [nongnu] elpa/dockerfile-mode 98434943c3 005/104: Adjust auto-mode regexp in README., ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 1015f3818d 016/104: Added copy and onbuild commands, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode a532e30371 023/104: Use syntax highlighting in README, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 6a64806b78 029/104: now treats single quotes like double quotes, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 34a0a5d082 030/104: Merge branch 'master' of github.com:spotify/dockerfile-mode, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 26239c3b95 043/104: Resolve spotify/#24, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode fdebd1eda5 044/104: Pass --build-args to docker build, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode c462ba8650 007/104: Merge pull request #1 from thomasf/master, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 730b2dbd84 010/104: Update Dockerfile keywords to match docker 0.7.6, ELPA Syncer, 2022/01/29
- [nongnu] elpa/dockerfile-mode 1fd094a409 009/104: Merge pull request #2 from purcell/patch-1, ELPA Syncer, 2022/01/29