emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/dockerfile-mode e20c7e587a 025/104: Correctly set require-


From: ELPA Syncer
Subject: [nongnu] elpa/dockerfile-mode e20c7e587a 025/104: Correctly set require-final-newline
Date: Sat, 29 Jan 2022 07:58:28 -0500 (EST)

branch: elpa/dockerfile-mode
commit e20c7e587a77ca5eabcb893b9b5687610b0e490c
Author: J Irving <j@lollyshouse.ca>
Commit: J Irving <j@lollyshouse.ca>

    Correctly set require-final-newline
    
    Emacs provides `mode-require-final-newline` to allow users to control
    the behaviour of modes (like `dockerfile-mode`) which are designed to
    control the final newline in a file. The intent is that this is set to
    `t` by default - modes that wish to ensure a final newline should set
    `require-final-newline` to `mode-require-final-newline`, allowing users
    to override this behaviour. See
    
    http://www.gnu.org/software/emacs/manual/html_node/emacs/Customize-Save.html
    
    for more detail.
    
    One specific use case where this is important is `ethan-wpace`, which
    implements a more sophisticated whitespace policy. Some examples of how
    sidestepping this convention can be a problem can be found in issues
    glasserc/ethan-wspace#22 and glasserc/ethan-wspace#25.
---
 dockerfile-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dockerfile-mode.el b/dockerfile-mode.el
index dba2fc37a0..a15f5b8473 100644
--- a/dockerfile-mode.el
+++ b/dockerfile-mode.el
@@ -97,7 +97,7 @@
 \\{dockerfile-mode-map}
 "
   (set-syntax-table dockerfile-mode-syntax-table)
-  (set (make-local-variable 'require-final-newline) t)
+  (set (make-local-variable 'require-final-newline) mode-require-final-newline)
   (set (make-local-variable 'comment-start) "#")
   (set (make-local-variable 'comment-end) "")
   (set (make-local-variable 'comment-start-skip) "#+ *")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]