[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 1a1ae03600 324/366: Remove transient--pre-com
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient 1a1ae03600 324/366: Remove transient--pre-command later |
Date: |
Tue, 25 Jan 2022 18:54:51 -0500 (EST) |
branch: externals/transient
commit 1a1ae036008ef152c7e77acab083133e346b9a67
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
Remove transient--pre-command later
Do it alongside the removal of `transient--pre-command' instead of as
early as possible. It just complicates matters if we treat these two
hook functions differently
---
lisp/transient.el | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index abfff6062d..1d2030cbaa 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -1959,7 +1959,6 @@ value. Otherwise return CHILDREN as is."
(transient--timer-cancel)
(transient--pop-keymap 'transient--transient-map)
(transient--pop-keymap 'transient--redisplay-map)
- (remove-hook 'pre-command-hook #'transient--pre-command)
(unless transient--showp
(let ((message-log-max nil))
(message "")))
@@ -1997,8 +1996,8 @@ value. Otherwise return CHILDREN as is."
(unless (> (minibuffer-depth) 1)
(unless transient--exitp
(transient--pop-keymap 'transient--transient-map)
- (transient--pop-keymap 'transient--redisplay-map)
- (remove-hook 'pre-command-hook #'transient--pre-command))
+ (transient--pop-keymap 'transient--redisplay-map))
+ (remove-hook 'pre-command-hook #'transient--pre-command)
(remove-hook 'post-command-hook #'transient--post-command)))
(defun transient--minibuffer-exit ()
@@ -2006,8 +2005,8 @@ value. Otherwise return CHILDREN as is."
(unless (> (minibuffer-depth) 1)
(unless transient--exitp
(transient--push-keymap 'transient--transient-map)
- (transient--push-keymap 'transient--redisplay-map)
- (add-hook 'pre-command-hook #'transient--pre-command))
+ (transient--push-keymap 'transient--redisplay-map))
+ (add-hook 'pre-command-hook #'transient--pre-command)
(add-hook 'post-command-hook #'transient--post-command)))
(defun transient--suspend-override (&optional minibuffer-hooks)
@@ -2041,6 +2040,7 @@ value. Otherwise return CHILDREN as is."
;; The current command could act as a prefix,
;; but decided not to call `transient-setup'.
(prog1 nil (transient--stack-zap))))
+ (remove-hook 'pre-command-hook #'transient--pre-command)
(remove-hook 'minibuffer-setup-hook #'transient--minibuffer-setup)
(remove-hook 'minibuffer-exit-hook #'transient--minibuffer-exit)
(advice-remove 'abort-recursive-edit #'transient--minibuffer-exit)
- [elpa] externals/transient 9a1d62699f 222/366: transient-force-fixed-pitch: Fix doc-string, (continued)
- [elpa] externals/transient 9a1d62699f 222/366: transient-force-fixed-pitch: Fix doc-string, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient d85eb790e8 235/366: transient-read-directory: Pass read value through file-local-name, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 48238bf580 236/366: Allow invoking arbitrary prefixes as non-suffixes, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient a3b442243b 241/366: transient-read-{, existing-}file: New functions, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c4bf4af655 020/366: transient--show-manpage: Fix jumping to argument, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e4ffb97a68 018/366: transient--layout-member: Match indirect key bindings, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 2d8ceff408 185/366: transient-setup: Add emergency exit, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 601ebf5547 262/366: Quote value of slots' :initform when defining classes, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient b526b9c735 281/366: transient-infix-set: Consider all incompatibility rules, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 459e28e28a 311/366: Add lisp-imenu-generic-expression entry, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 1a1ae03600 324/366: Remove transient--pre-command later,
Jonas Bernoulli <=
- [elpa] externals/transient e90f7a165e 335/366: Add support for returning from a sub-prefix to the parent prefix, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 8b1f8dcc51 354/366: transient--minibuffer-depth: Must always be a number, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 5762bd9a06 341/366: transient-hide-during-minibuffer-read: New option, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient de5a325616 349/366: Re-align debug declarations, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 6103f168aa 347/366: transient--describe-function: Deal with anonymous infix arguments, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 4477555b17 366/366: transient--post-exit: Deal with unbound transient slot properly, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient ad7f255308 116/366: For popups set tab-line-format to nil, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 0ad64ddc5d 010/366: transient-remove-suffix: Fix removal of last child of a group, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient f2ef69cfcc 176/366: transient--get-predicate-for: New function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient f2252d53b6 188/366: Support delaying setup of suffixes until prefix invocation, Jonas Bernoulli, 2022/01/25