emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/transient 601ebf5547 262/366: Quote value of slots' :in


From: Jonas Bernoulli
Subject: [elpa] externals/transient 601ebf5547 262/366: Quote value of slots' :initform when defining classes
Date: Tue, 25 Jan 2022 18:54:46 -0500 (EST)

branch: externals/transient
commit 601ebf55475856f64c03a4393472302a2d65af2a
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    Quote value of slots' :initform when defining classes
    
    The behavior of `:initform' changes in Emacs 28:
    
    > Change the implementation of `:initform` to better match the CLOS
    > semantics, while preserving the EIEIO semantics, but warn when
    > encountering cases where the two diverge.
    
    As a result we have to quote the name of two functions.
    
    We also have to obfuscate using the value of a variable in another
    instance because the transitional code would otherwise not be able
    to tell whether this is intentional or assumes the old semantics.
---
 lisp/transient.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/transient.el b/lisp/transient.el
index 4a8e59f17b..ecb94ab591 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -576,7 +576,7 @@ the prototype is stored in the clone's `prototype' slot.")
 (defclass transient-child ()
   ((level
     :initarg :level
-    :initform transient--default-child-level
+    :initform (symbol-value 'transient--default-child-level)
     :documentation "Enable if level of prefix is equal or greater.")
    (if
     :initarg :if
@@ -3599,9 +3599,9 @@ we stop there."
 ;;;; `transient-lisp-variable'
 
 (defclass transient-lisp-variable (transient-variable)
-  ((reader :initform transient-lisp-variable--reader)
+  ((reader :initform #'transient-lisp-variable--reader)
    (always-read :initform t)
-   (set-value :initarg :set-value :initform set))
+   (set-value :initarg :set-value :initform #'set))
   "[Experimental] Class used for Lisp variables.")
 
 (cl-defmethod transient-init-value ((obj transient-lisp-variable))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]