[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 101c0aeaa1 023/366: transient--insert-suffix:
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient 101c0aeaa1 023/366: transient--insert-suffix: Fix move of last child of a group |
Date: |
Tue, 25 Jan 2022 18:54:23 -0500 (EST) |
branch: externals/transient
commit 101c0aeaa173f6d2b14f027c8372cae88d261db4
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
transient--insert-suffix: Fix move of last child of a group
When adding a suffix using `transient-{insert,append}-suffix' then
an existing binding for the same command is removed, if any. This
is necessary to either *move* the suffix binding or to replace it
with an alternative binding for the same command. This can also
happen when the same form gets evaluated twice, which can happen
if it is autoloaded.
When the suffix is the last child of a group, then this was broken.
This is the same bug as was fixed with 0ad64ddc5db466fb3bcac67b931,
but in a different function.
Fixes #20.
---
lisp/transient.el | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index ba1210ffe6..b3e7da6363 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -771,11 +771,7 @@ example, sets a variable use `define-infix-command'
instead.
(mem (transient--layout-member prefix loc)))
(if mem
(progn
- (when-let ((old (transient--layout-member
- prefix (plist-get (nth 2 suf) :command))))
- (setcar old (cadr old))
- (setcdr old (cddr old))
- (setq mem (transient--layout-member prefix loc)))
+ (transient-remove-suffix prefix (plist-get (nth 2 suf) :command))
(cl-ecase action
(insert (setcdr mem (cons (car mem) (cdr mem)))
(setcar mem suf))
- [elpa] externals/transient 2ad749e1fa 081/366: Fix doc-string typo, (continued)
- [elpa] externals/transient 2ad749e1fa 081/366: Fix doc-string typo, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 71687ba790 085/366: No longer allow characters as pseudo suffixes, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 62b18fef2b 115/366: transient-mode-line-format: Don't without a window-system, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 75de1f0418 120/366: transient-detect-key-conflicts: But without locking Emacs, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c59c48530a 122/366: transient--{suspend, resume}-override: New functions, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient ebcad9e6fe 127/366: Use seq instead of dash, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient d49f85a8c1 158/366: Support scroll-bar-toolkit-scroll, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7502390bbd 190/366: transient-column{, s}: Optionally pad keys, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient f0f3e2b9fe 195/366: transient-infix-value: Fix typo in a doc-string, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 8423bc69e7 199/366: manual: Update outdated function signature, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 101c0aeaa1 023/366: transient--insert-suffix: Fix move of last child of a group,
Jonas Bernoulli <=
- [elpa] externals/transient 0d9a1b5536 107/366: manual: Document prefix slots, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7e2b98c701 109/366: Fix doc string typo, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 3fe1b7ea86 086/366: transient--kbd: New function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 0312b9302d 099/366: transient-args: Remove SEPARATE argument, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7d0db2826b 100/366: transient-args: No longer support an object as PREFIX, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient a6ce1950e4 102/366: transient-args: Fall back to set, saved or default value, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 0cad5ebcb7 106/366: Fix doc string typos, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 824c684deb 108/366: Advertise current-transient-suffixes less, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient ccac95e5a8 112/366: transient-show-help: Don't error if argument is missing, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 4f80a8999c 113/366: transient--goto-argument-description: Handle -- special case, Jonas Bernoulli, 2022/01/25