[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/transient 71687ba790 085/366: No longer allow character
From: |
Jonas Bernoulli |
Subject: |
[elpa] externals/transient 71687ba790 085/366: No longer allow characters as pseudo suffixes |
Date: |
Tue, 25 Jan 2022 18:54:29 -0500 (EST) |
branch: externals/transient
commit 71687ba790dedffcb2527d4a37d6a3017149408c
Author: Jonas Bernoulli <jonas@bernoul.li>
Commit: Jonas Bernoulli <jonas@bernoul.li>
No longer allow characters as pseudo suffixes
The only potentially useful character were ?\n and ?\s but "" has the
same effect as these two. Unlike integers two `equal' strings are not
also `eq', which means that attempting to remove an integer by
position (to be implemented in subsequent commits) would always remove
the first `eq' integer instead of the specified one.
---
lisp/transient.el | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/lisp/transient.el b/lisp/transient.el
index 7937cc065e..c44782f676 100644
--- a/lisp/transient.el
+++ b/lisp/transient.el
@@ -758,8 +758,7 @@ example, sets a variable use `define-infix-command' instead.
(cl-etypecase spec
(vector (when-let ((c (transient--parse-group prefix spec))) (list c)))
(list (when-let ((c (transient--parse-suffix prefix spec))) (list c)))
- (string (list spec))
- (integer (list spec))))
+ (string (list spec))))
(defun transient--parse-group (prefix spec)
(setq spec (append spec nil))
@@ -1443,7 +1442,6 @@ EDIT may be non-nil."
(setq transient--suffixes
(cl-labels ((s (def)
(cond
- ((integerp def) nil)
((stringp def) nil)
((listp def) (cl-mapcan #'s def))
((transient-group--eieio-childp def)
@@ -1456,8 +1454,7 @@ EDIT may be non-nil."
(cl-etypecase spec
(vector (transient--init-group levels spec))
(list (transient--init-suffix levels spec))
- (string (list spec))
- (integer (list spec))))
+ (string (list spec))))
(defun transient--init-group (levels spec)
(pcase-let ((`(,level ,class ,args ,children) (append spec nil)))
@@ -2500,8 +2497,7 @@ have a history of their own.")
(dolist (suffix (oref group suffixes))
(let ((str (transient-format suffix)))
(insert str)
- (unless (or (integerp suffix)
- (string-match-p ".\n\\'" str))
+ (unless (string-match-p ".\n\\'" str)
(insert ?\n)))))
(cl-defmethod transient--insert-group ((group transient-columns))
- [elpa] externals/transient e85b3e5241 007/366: manual: Fix a typo, (continued)
- [elpa] externals/transient e85b3e5241 007/366: manual: Fix a typo, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient b155eec353 011/366: transient--suffix-command: Fix doc-string typos, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient ebbe32e14d 028/366: transient--insert-groups: New function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 70729dd620 043/366: transient-set-level: Disallow 0 as prefix level, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 3668aeb81d 053/366: transient--history-key: New generic function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient e627d45166 054/366: transient-prefix: Add new history-key slot, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 8a0428e037 056/366: transient-args: Remove unnecessary form, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 47b79754e3 055/366: transient--history-push: Define as generic function, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 61e631aa6d 068/366: transient-history: Fix doc-string quoting, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 2ad749e1fa 081/366: Fix doc-string typo, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 71687ba790 085/366: No longer allow characters as pseudo suffixes,
Jonas Bernoulli <=
- [elpa] externals/transient 62b18fef2b 115/366: transient-mode-line-format: Don't without a window-system, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 75de1f0418 120/366: transient-detect-key-conflicts: But without locking Emacs, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient c59c48530a 122/366: transient--{suspend, resume}-override: New functions, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient ebcad9e6fe 127/366: Use seq instead of dash, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient d49f85a8c1 158/366: Support scroll-bar-toolkit-scroll, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 7502390bbd 190/366: transient-column{, s}: Optionally pad keys, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient f0f3e2b9fe 195/366: transient-infix-value: Fix typo in a doc-string, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 8423bc69e7 199/366: manual: Update outdated function signature, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 101c0aeaa1 023/366: transient--insert-suffix: Fix move of last child of a group, Jonas Bernoulli, 2022/01/25
- [elpa] externals/transient 0d9a1b5536 107/366: manual: Document prefix slots, Jonas Bernoulli, 2022/01/25