[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/eglot cbb1da42be 12/33: Let eglot-flymake-backend be in
From: |
Stefan Kangas |
Subject: |
[elpa] externals/eglot cbb1da42be 12/33: Let eglot-flymake-backend be in flymake-d-functions even if Eglot off |
Date: |
Sat, 8 Jan 2022 12:30:49 -0500 (EST) |
branch: externals/eglot
commit cbb1da42be65fe7e6105d4638b889180f2a1b17d
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>
Let eglot-flymake-backend be in flymake-d-functions even if Eglot off
This is useful when using eglot-stay-out-of and a pattern like:
(defun my/js-mode-hook ()
(add-hook 'flymake-diagnostic-functions 'some-eslint-backend nil t))
(setq-local eglot-stay-out-of '(flymake))
(add-hook 'flymake-diagnostic-functions 'eglot-flymake-backend nil t))
(add-hook 'js-mode-hook 'my/js-mode-hook)
Then, _both_ backends will run unconditionally, but Eglot backend only
actually reports diagnostics if Eglot is on.
* eglot.el (eglot-flymake-backend): If buffer isn't being managed
by Eglot, behave as a noop.
---
eglot.el | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/eglot.el b/eglot.el
index 0f367fd220..71f7d7ea59 100644
--- a/eglot.el
+++ b/eglot.el
@@ -2089,10 +2089,13 @@ Calls REPORT-FN (or arranges for it to be called) when
the server
publishes diagnostics. Between calls to this function, REPORT-FN
may be called multiple times (respecting the protocol of
`flymake-backend-functions')."
- (setq eglot--current-flymake-report-fn report-fn)
- ;; Report anything unreported
- (when eglot--unreported-diagnostics
- (eglot--report-to-flymake (cdr eglot--unreported-diagnostics))))
+ (cond (eglot--managed-mode
+ (setq eglot--current-flymake-report-fn report-fn)
+ ;; Report anything unreported
+ (when eglot--unreported-diagnostics
+ (eglot--report-to-flymake (cdr eglot--unreported-diagnostics))))
+ (t
+ (funcall report-fn nil))))
(defun eglot--report-to-flymake (diags)
"Internal helper for `eglot-flymake-backend'."
- [elpa] externals/eglot 5cc8df63d8 08/33: Fix #702: Consider TRAMP in eglot-alternatives, (continued)
- [elpa] externals/eglot 5cc8df63d8 08/33: Fix #702: Consider TRAMP in eglot-alternatives, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 0e6c0619da 09/33: Fix #703: Don't call eglot--executable-find more than needed, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot c17bdf6c98 16/33: Fixup last commit, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 8b15bf726f 19/33: Test javascript-basic with typescript-language-server, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 44793b6e07 20/33: Fix issues #755, #401; severity not set in textDocument/publishDiagnostics, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot b197e092f9 33/33: ; Fix typos, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 91b3f60d67 31/33: Add yaml-language-server for yaml-mode, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 04d2d6f783 02/33: Fix #649: two typos, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot e498cb171b 07/33: Per #697: Use project-files to know which directory watchers to skip, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 25d20c73cf 05/33: Fix #697, #645: Again speed up directory watching, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot cbb1da42be 12/33: Let eglot-flymake-backend be in flymake-d-functions even if Eglot off,
Stefan Kangas <=
- [elpa] externals/eglot a697084d8d 13/33: Fix #719: fall back to prompting user if eglot-alternatives fails, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 1612289ae4 18/33: Fix eglot--tramp-test-2 so it skips without clangd, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 9665359bb6 17/33: Fix workspace/configuration handling when given scopeUri directory, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 7b1055a188 21/33: Merge commit '8b15bf726faa2d753933a212c3426a63cabab21c', Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 55c13a9137 22/33: Merge pull request #759 from stephe-ada-guru/master, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 35994ca8cb 27/33: ; Prefer HTTPS to HTTP addresses, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 358104a5f0 29/33: Mention support for F# in README, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 761901bd55 30/33: Per #662, add a note to the README about updating TRAMP to 2.5.0.4+, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot 2410637c17 32/33: Use fortls also for fortran-mode, Stefan Kangas, 2022/01/08
- [elpa] externals/eglot ba1a6c9b39 10/33: Per #703: transpose order of "pylsp" and "pyls" alternatives, Stefan Kangas, 2022/01/08