emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/eglot c17bdf6c98 16/33: Fixup last commit


From: Stefan Kangas
Subject: [elpa] externals/eglot c17bdf6c98 16/33: Fixup last commit
Date: Sat, 8 Jan 2022 12:30:49 -0500 (EST)

branch: externals/eglot
commit c17bdf6c98d6bf0f1a85f1175556e1038654402f
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>

    Fixup last commit
    
    Per #726.
    
    I'm still not entirely convinced using all-completion here is a good
    idea.  As usual the completion list we get from the server is
    pre-filtered to whatever the server wishes.  Letting the completion
    style do its own filtering (most completion styles use
    completion-regexp-list and all-completions themselves) is completely
    useless here.
    
    Let's hope it's not harmful.
    
    * eglot.el (eglot-completion-at-point): Fix all-completions call
---
 eglot.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/eglot.el b/eglot.el
index e8b7ffbbb1..7ebc422451 100644
--- a/eglot.el
+++ b/eglot.el
@@ -2371,8 +2371,7 @@ is not active."
                      (filterText (plist-get item :filterText)))
                 (and (or (null pred) (funcall pred proxy))
                      (string-prefix-p
-                      probe (or filterText proxy) completion-ignore-case))))
-            (funcall proxies)))))
+                      probe (or filterText proxy) 
completion-ignore-case))))))))
        :annotation-function
        (lambda (proxy)
          (eglot--dbind ((CompletionItem) detail kind)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]