Re: empty-directory predicate, native implementation

[Michael Albinus]

Arthur Miller <arthur.miller@live.com> writes:

Hi Arthur,

>> Thanks for this. I haven't seen your name on the FSF file; I guess your
>> legal papers are on the way?
> They are not, but they can be if someone send me link. I've been looking
> at this page:
>
> https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html#Copyright-Papers
>
> but I am not really sure where do I send request.

Sorry, I should have asked. I'll send you the template off-list.

>> - Adapt the file name handlers. These are ange-ftp-directory-files,
>>   ange-ftp-directory-files-and-attributes, tramp-handle-directory-files,
>>   tramp-handle-directory-files-and-attributes,
>>   tramp-adb-handle-directory-files-and-attributes,
>>   tramp-crypt-handle-directory-files,
>>   tramp-rclone-handle-directory-files,
>>   tramp-sh-handle-directory-files-and-attributes,
>>   tramp-smb-handle-directory-files.
>
> Aha, so it is how it works; didn't have time to look into tramp yet.
> Ok, I'll do; I'll sent in patch(es) when I am done. Probably not today
> though but during the weekend of beginning of the next week.

There's no rush. Doing the legal work will take a week or so.

> So many changes just for one signature :-).

In order to enjoy you: Tramp is backward compatible back to Emacs
25. This must also be taken into account :-)

But don't worry, I'll make the needed changes after your commit.

>> - Adapt resp extend ERT tests. These are tramp-test16-directory-files,
>>   tramp-test19-directory-files-and-attributes,
>>   tramp-archive-test16-directory-files and
>>   tramp-archive-test19-directory-files-and-attributes.
>>
>> - Optionally (but much appreciated), write new ERT tests for
>>   directory-files and directory-files-and-attributes.
>
> Will have to look at ERT, I suppose it is not too complicated,
> opportunity to learn it.

A look at the ert manual might help. (info "(ert)")

> I mainly try to be clear "what I intent" for some future reader; since
> previous code uses lisp.h macros, I used same. I thought that one extra
> 'if' is not that much of a penalty, I'll gladly shortcircut with !last.

In case you feel the need, you could also provide a comment.

Best regards, Michael.