[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Tests and linting not coupled to one file (was: Re: master 664927b: Add
From: |
Stefan Kangas |
Subject: |
Tests and linting not coupled to one file (was: Re: master 664927b: Add an expensive test for defcustom types) |
Date: |
Fri, 25 Sep 2020 06:11:32 -0700 |
larsi@gnus.org (Lars Ingebrigtsen) writes:
> branch: master
> commit 664927b5257fdaf26f24063edb1f41c407805ed8
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Add an expensive test for defcustom types
>
> * admin/cus-test.el (cus-test-opts): Return the tests.
>
> * test/lisp/custom-tests.el (check-for-wrong-custom-types): Test
> custom types (bug#30990).
Thanks.
I have been thinking about what to with this kinds of expensive
tests/linting. It is of course good that we now run the above
automatically, since it will help us catch bugs. But it isn't very
clean conceptually to add such a test to "custom-tests.el", since it
operates on the entire code base instead of just one file/component.
One idea I've had is to create a new directory "test/misc" or something
to keep such tests in. We could arrange for them to be run with
"check-expensive" and continue using ert to get standardized reporting,
etc.
The custom tests are good candidates here, but there are others.
- Tests and linting not coupled to one file (was: Re: master 664927b: Add an expensive test for defcustom types),
Stefan Kangas <=