[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Warnings in mingw64 builds on master

From: Eli Zaretskii
Subject: Re: Warnings in mingw64 builds on master
Date: Sun, 16 Aug 2020 18:39:13 +0300

> Cc: andrewjmoreton@gmail.com, emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sun, 16 Aug 2020 08:25:33 -0700
> >>> I'd rather we removed -Wsuggest-attribute=malloc from the options we use.
> >>
> >> That option is useful for the non-w32 source code.
> > 
> > Useful how?
> It lets both the human reader and the compiler know that the storage 
> addressed 
> by the function's result cannot alias with any other storage. I find this 
> helpful when reading the code because it lets me not worry about aliasing, 
> and 
> compilers can use this info to generate more-efficient code.

I think you described what __attribute__((malloc)) does.  But that's
not what I asked; I asked why do we need to put that warning option
into the list of options with which we compile.  It sounds like a
specialized option intended for maintainers when they want to find
ways to improve the code, because the warning it emits has nothing to
do with correctness of the code.

So I think we should by default disable it.  Those who find it useful
can always enable it locally.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]