|
From: | Andrea Corallo |
Subject: | Re: [PATCH] [WIP] Port feature/native-comp to Windows. |
Date: | Sun, 10 May 2020 10:13:08 -0700 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Nicolas Bértolo <address@hidden> writes: > What do you think? If you use gcc_jit_context_add_driver_option you need to check for its presence because I added it only for GCC9 and in not in all libgccjits. You can do it with the macro LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option or checking for the ABI tag LIBGCCJIT_ABI_11. We should do that at configure time tho. That said I think a problem of this solution is that you limit the compatibility to 1 year old GCCs that is quite strict. I wrote all the rest of the code trying not to use recent entry points on purpose. It should be possible to use recent entry points but only with a fallback. This unless we see there's really no other option and we accept the trade off. For the rest I do not have Windows knowledge so to form an opinion I'd need to understand a little more how it works. In case you have some reference to recommend please feel free to suggest. Andrea -- address@hidden
[Prev in Thread] | Current Thread | [Next in Thread] |