[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [WIP] Port feature/native-comp to Windows.
From: |
Andrea Corallo |
Subject: |
Re: [PATCH] [WIP] Port feature/native-comp to Windows. |
Date: |
Wed, 13 May 2020 14:31:51 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Nicolas Bértolo <address@hidden> writes:
>> I think Qjson is a refuse from kill and yank.
>
> Heh, it turns out that fixing that uncovered a bug. We need to clear
> Vlibrary_cache when loading a dump (or prevent it from being dumped) because
> otherwise it will have a `gccjit` entry from when temacs loaded libgccjit and
> then w32_delayed_load() will think that libgccjit is already loaded in the
> process.
>
> New version attached.
Hi Nicolas, thanks
+ static bool tried_to_initialize_once;
+ static bool gccjit_initialized;
+
+ if (!tried_to_initialize_once)
+ {
+ tried_to_initialize_once = true;
+ Lisp_Object status;
+ gccjit_initialized = init_gccjit_functions ();
+ status = gccjit_initialized ? Qt : Qnil;
+ Vlibrary_cache = Fcons (Fcons (Qgccjit, status), Vlibrary_cache);
+ }
+
+ if (mandatory && !gccjit_initialized)
+ xsignal1(Qnative_compiler_error, build_string("libgccjit not found"));
+
+ return gccjit_initialized;
I see you have introduced tried_to_initialize_once. I'm not sure this
is convenient because a user could, after a failed attempt, fix his
environment to load libgccjit and do it without restarting Emacs.
Is there some specific reason for this choice?
> PS: Shall I open a bug where we can track this?
If affect all Emacs I think is the right thing to do.
> Nicolas
Thanks!
Andrea
--
address@hidden
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., (continued)
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/11
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows.,
Andrea Corallo <=
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Richard Stallman, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10