Re: Question about display engine

[martin rudalics]

> Could any of you give a look to the patch

I cannot build Emacs on Windows with the patch due to


  CC       w32select.o
../../src/w32term.c: In function 'w32_draw_glyph_string':
../../src/w32term.c:2482:20: error: 'struct face' has no member named 
'underline_p'; did you mean 'underline'?
       if (s->face->underline_p)
                    ^~~~~~~~~~~
                    underline
../../src/w32term.c:2484:24: error: 'struct face' has no member named 
'underline_type'; did you mean 'underline_color'?
           if (s->face->underline_type == FACE_UNDER_WAVE)
                        ^~~~~~~~~~~~~~
                        underline_color
../../src/w32term.c:2495:29: error: 'struct face' has no member named 
'underline_type'; did you mean 'underline_color'?
           else if (s->face->underline_type == FACE_UNDER_LINE)
                             ^~~~~~~~~~~~~~
                             underline_color
../../src/w32term.c:2500:45: error: 'struct face' has no member named 
'underline_p'; did you mean 'underline'?
               if (s->prev && s->prev->face->underline_p
                                             ^~~~~~~~~~~
                                             underline
../../src/w32term.c:2501:23: error: 'struct face' has no member named 
'underline_type'; did you mean 'underline_color'?
     && s->prev->face->underline_type == FACE_UNDER_LINE)
                       ^~~~~~~~~~~~~~
                       underline_color
make[1]: *** [Makefile:402: w32term.o] Fehler 1
make[1]: *** Es wird auf noch nicht beendete Prozesse gewartet....
make[1]: Verzeichnis „/c/emacs/trunk/non-64/src“ wird verlassen
make: *** [Makefile:424: src] Fehler 2


and since I don't understand the underline_p/_type rationale I have no
good idea how to proceed.

> to detect what is failing at
> least to triger the merge and extend?
> Probably the initialization. (which btw the lisp glue code may be buggy
> for sure.)

I'd run Emacs under gdb to find out whether merge_extend_glyph_face
gets called in the first place.  And if it doesn't get called, I would
continue investigating the places where it should get called.

martin