[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve Gravatar support

From: Basil L. Contovounesios
Subject: Re: [PATCH] Improve Gravatar support
Date: Mon, 22 Jul 2019 22:44:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Lars Ingebrigtsen <address@hidden> writes:

> After skimming (on holiday), looks good to me.

Thanks, enjoy your holiday!  There's no rush on my part.

> Extremely minor comments below:
> "Basil L. Contovounesios" <address@hidden> writes:
>>  (defcustom gnus-gravatar-too-ugly gnus-article-x-face-too-ugly
>> -  "Regexp matching posters whose avatar shouldn't be shown automatically."
>> -  :type '(choice regexp (const nil))
>> +  "Regexp matching posters whose avatar shouldn't be shown automatically.
>> +Nil means show all avatars."
> We don't capitalise nil in documentation, do we?

"git grep '\<Nil\>'" returns only a few hits, so I guess you're right.
Will change.

>> -      ;; The buffer can be gone at this time
>> -      (when (buffer-live-p (current-buffer))
>> +      ;; The buffer can be gone at this time.
>> +      (when (buffer-name)
> I think buffer-live-p is clearer than just saying buffer-name.


>> -  (interactive (list t)) ;; When type `W D g'
>> +  (interactive "p") ;; When type `W D g'
> Perhaps grammer fix?

I'd rather remove these comments altogether, if that's okay with you.
The default key bindings are not important here, and it's tautological
to say that the interactive spec takes effect when the function is
called as the result of a key binding.

These changes are now included in the split patch set in my other



reply via email to

[Prev in Thread] Current Thread [Next in Thread]