[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve Gravatar support

From: Eli Zaretskii
Subject: Re: [PATCH] Improve Gravatar support
Date: Tue, 23 Jul 2019 05:31:37 +0300

> From: "Basil L. Contovounesios" <address@hidden>
> Date: Mon, 22 Jul 2019 22:42:27 +0100
> Cc: address@hidden
> Since the first patch only touches existing documentation, it could even
> be applied to emacs-26.  Eli?

Fine with me, but:

> -@pxref{Image Descriptors, ,Image Descriptors, elisp, The Emacs Lisp
> -Reference Manual} for the valid properties for various image types.
> -Currently, @code{pbm} is used for X-Face images and @code{png} is used
> -for Face images in Emacs.  Only the @code{:face} property is effective
> -on the @code{xface} image type in XEmacs if it is built with the
> +For the valid properties of various image types, @pxref{Image
> +Descriptors,,, elisp, The Emacs Lisp Reference Manual}.  Currently,

This part is better solved by simply replacing @pxref with @xref, and
adding a comma after the closing brace.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]