Re: Emacs release branch warnings with GCC 8

[Paul Eggert]

On 04/30/2018 12:38 PM, Eli Zaretskii wrote:
> But a release tarball is not built with --enable-gcc-warnings by
> default, right?

Right. This is about people who build from a release tarball with 
--enable-gcc-warnings, and about people who build from Git (the latter 
appear to be a growing number....).

> > I've patched the master to fix this problem in commits
> > 2b9ab8c8fba849da8bf2aa45e65b122bb937a6b3 and
> > 8c3215e7a47e3caaa005bf573765ed63e0739b89, and could backport these
> > patches (or a subset) to emacs-26 if there's interest.
> I'm okay with the first one, but I don't understand how the warnings
> you've shown are related to the ATTRIBUTE_MALLOC changes in the second
> commit.

The first commit enables -Wsuggest-attribute=malloc, and the 
ATTRIBUTE_MALLOC changes in the second commit then pacifies GCC in that 
area. We could change the first commit to not enable 
-Wsuggest-attribute=malloc and this would simplify the second commit, 
though we'd then be differing from Gnulib in the first commit.