emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Dynamic loading progress


From: Aurélien Aptel
Subject: Re: Dynamic loading progress
Date: Sun, 25 Oct 2015 19:45:09 +0100

On Sun, Oct 25, 2015 at 5:31 PM, Philipp Stephani <address@hidden> wrote:
> I mainly use Clang, which is almost, but not entirely compatible with GCC.
> If the flag causes problems for you, just drop it, of course it's not
> required.

Sure, but it looks useful so I'd like to make it work.

In any case I've merged you PR and I've finished the `load'
integration, which makes `require' works now.

`Fload' does a lot of stuff and I'm short-circuiting a lot of it for
modules. I would like some review on this [1] specifically src/lread.c
changes. Do we need to do things before the function returns? I'm
guessing we should close the fd returned by `openp' but if you grep
for openp usage in the emacs codebase you'll notice some occurence
where they don't even store the fd...

https://github.com/aaptel/emacs-dynamic-module/commit/dc5cc38a50ea31b0d64c6664352c3bce88121411



reply via email to

[Prev in Thread] Current Thread [Next in Thread]