Re: bookmark.el bug report

[Thierry Volpiatto]

Karl Fogel <address@hidden> writes:

> Karl Fogel <address@hidden> writes:
>>------------------------------------------------------------
>>revno: 99229
>>revision-id: address@hidden
>>parent: address@hidden
>>committer: Karl Fogel <address@hidden>
>>branch nick: trunk
>>timestamp: Fri 2010-01-01 23:36:17 -0500
>>message:
>>  * lisp/bookmark.el: Improvements suggested by Drew Adams:
>>    (bookmark-bmenu-ensure-position): New name for
>>    `bookmark-bmenu-check-position'.  Just ensure the position;
>>    don't return any meaningful value.
>>    (bookmark-bmenu-header-height, bookmark-bmenu-marks-width): New constants.
>
> And if I could edit the commit message for this one, I'd add:
>
>   (everywhere): Adjust former callers of `bookmark-bmenu-check-position'
>   to call `bookmark-bmenu-ensure-position' instead, and to not use the
>   return value.

There is one bug also in bookmark-bmenu-hide-filenames where you forget
to put properties on bookmark when rebuilding.
So after one use of hide-/show-filenames, bookmark-bmenu-bookmark
doesn't work anymore because bookmark have no properties.

I sent a patch to Stefan.

-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France