emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bookmark.el bug report


From: Karl Fogel
Subject: Re: bookmark.el bug report
Date: Sat, 02 Jan 2010 00:15:09 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux)

Karl Fogel <address@hidden> writes:
>------------------------------------------------------------
>revno: 99229
>revision-id: address@hidden
>parent: address@hidden
>committer: Karl Fogel <address@hidden>
>branch nick: trunk
>timestamp: Fri 2010-01-01 23:36:17 -0500
>message:
>  * lisp/bookmark.el: Improvements suggested by Drew Adams:
>    (bookmark-bmenu-ensure-position): New name for
>    `bookmark-bmenu-check-position'.  Just ensure the position;
>    don't return any meaningful value.
>    (bookmark-bmenu-header-height, bookmark-bmenu-marks-width): New constants.

And if I could edit the commit message for this one, I'd add:

  (everywhere): Adjust former callers of `bookmark-bmenu-check-position'
  to call `bookmark-bmenu-ensure-position' instead, and to not use the
  return value.

Sigh.  I don't miss CVS, but being able to fix log messages is nice.

-K




reply via email to

[Prev in Thread] Current Thread [Next in Thread]