emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mouse-1-click-follows-link with t-mouse


From: Nick Roberts
Subject: Re: mouse-1-click-follows-link with t-mouse
Date: Mon, 19 Mar 2007 23:17:12 +1200

 > > When is this condition needed?  I couldn't get it to fail on a graphical
 > > display.
 > 
 > I don't recall why I made the check for input-pending-p, but
 > it looks like it is meant to catch a double click on a link - 
 > i.e. so that a double-click does not follow the link.
 > 
 > But that doesn't really work - and it also seems that the test could
 > potentially make the whole feature unstable, as other unrelated input
 > events could accidentally prevent the mouse click from following the link.
 > 
 > So I think we can just remove the test.

That would be good.  The client program mev, used by t-mouse, outputs time
information which isn't currently used in t-mouse.el.  The patch below allows
Emacs to follow the delay specified by mouse-1-click-follows-link in a
console.

-- 
Nick                                           http://www.inet.net.nz/~nickrob



*** t-mouse.el  20 Jan 2007 20:58:47 +1300      1.7
--- t-mouse.el  19 Mar 2007 23:08:57 +1200      
*************** For example, \"2\" for /dev/tty2."
*** 134,147 ****
  
  (defun t-mouse-make-event-element (x-dot-y-avec-time)
    (let* ((x-dot-y (nth 0 x-dot-y-avec-time))
           (x (car x-dot-y))
           (y (cdr x-dot-y))
           (w (window-at x y))
           (ltrb (window-edges w))
           (left (nth 0 ltrb))
!          (top (nth 1 ltrb)))
!     (if w (posn-at-x-y (- x left) (- y top) w t)
!       (append (list nil 'menu-bar) (nthcdr 2 (posn-at-x-y x y w t))))))
  
  ;;; This fun is partly Copyright (C) 1994 Per Abrahamsen <address@hidden>
  (defun t-mouse-make-event ()
--- 134,152 ----
  
  (defun t-mouse-make-event-element (x-dot-y-avec-time)
    (let* ((x-dot-y (nth 0 x-dot-y-avec-time))
+        (time (nth 1 x-dot-y-avec-time))
           (x (car x-dot-y))
           (y (cdr x-dot-y))
           (w (window-at x y))
           (ltrb (window-edges w))
           (left (nth 0 ltrb))
!          (top (nth 1 ltrb))
!        (event (if w
!                   (posn-at-x-y (- x left) (- y top) w t)
!                 (append (list nil 'menu-bar)
!                         (nthcdr 2 (posn-at-x-y x y w t))))))
!     (setcar (nthcdr 3 event) time)
!     event))
  
  ;;; This fun is partly Copyright (C) 1994 Per Abrahamsen <address@hidden>
  (defun t-mouse-make-event ()




reply via email to

[Prev in Thread] Current Thread [Next in Thread]