[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Problem report #7
From: |
Stuart D. Herring |
Subject: |
Re: Problem report #7 |
Date: |
Tue, 11 Apr 2006 10:09:26 -0700 (PDT) |
User-agent: |
SquirrelMail/1.4.3a-11.EL3 |
> 3815 if ((fd = emacs_open (SDATA (filename), O_RDONLY, 0)) < 0
> 3816 || fstat (fd, &st) < 0)
> 3817 #endif /* not APOLLO */
> 3818 #endif /* WINDOWSNT */
This code can certainly assign interesting values to fd.
> 3819 {
>
> Event dead_error_line: Cannot reach this line of code
> Event dead_error_condition: On this path, the condition "fd >= 0" could
> not be true
> Also see events: [dead_error_condition][assignment][const]
>
> 3820 if (fd >= 0) emacs_close (fd);
So this test isn't useless. But maybe this line should be moved to just
under the emacs_open() call, since it's only useful there? This fails to
imply any dangerous bug, in any event.
Davis
--
This product is sold by volume, not by mass. If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.