bug#49766: closed ([PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.)

[GNU bug Tracking System]

Your message dated Tue, 10 Aug 2021 17:13:17 +0200
with message-id <87h7fxqqnm.fsf_-_@gnu.org>
and subject line Re: bug#49766: [PATCH] gnu: rocksdb: set TEST_TMPDIR for 
faster test i/o.
has caused the debbugs.gnu.org bug report #49766,
regarding [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49766: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49766
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
>
>
>
>
> Date: 
>
> Wed, 28 Jul 2021 22:00:26 -0700
>
>
>
>
> The rocksdb test can take an egregious amount of time on a spinning HDD.
> This will inherit guixbuild's /tmp mount for the rocksdb testing
> directory.
>
> * gnu/packages/databases.scm (rocksdb)[arguments]: set TEST_TMPDIR for
> check phase
> ---
>  gnu/packages/databases.scm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index 5de79de955..cd19d14950 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -1395,10 +1395,19 @@ including field and record folding.")))
>                 (("install: install-static")
>                  "install: install-shared")
>                 (("#!/bin/sh") (string-append "#!" (which "sh"))))
> -             #t))
> +             #t)) 
>           (delete 'configure)
>           ;; The default target is only needed for tests and built on demand.
>           (delete 'build)
> +         (add-before 'check 'mount-tmp
> +           ;; Use the provided workspace directory for test files.
> +           ;; Otherwise, /tmp is used which is a mount namespace on /gnu/store.
> +           ;; This speeds up the build when the host /tmp is a proper tmpfs or
> +           ;; other fast filesystem, as opposed to /gnu which may be a HDD.
> +           (lambda _
> +             (let ((test-dir (string-append (getcwd) "/../test")))
> +               (mkdir test-dir)
> +               (setenv "TEST_TMPDIR" (canonicalize-path test-dir)))))
>           (add-before 'check 'disable-optimizations
>             (lambda _
>               ;; Prevent the build from passing '-march=native' to the compiler.
> @@ -1429,6 +1438,7 @@ including field and record folding.")))
>         ("perl" ,perl)
>         ("procps" ,procps)
>         ("python" ,python-2)
> +       ("util-linux" ,util-linux)
>         ("which" ,which)))
>      (inputs
>       `(("bzip2" ,bzip2)
> -- 
> 2.31.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#49766: [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
>
>
>
>
> Date: 
>
> Tue, 10 Aug 2021 17:13:17 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi,
>
> Ryan Sundberg <ryan@arctype.co> skribis:
>
> > I give up with git send-email, here is the darn patch file. From
> > Thunderbird.
>
> :-)
>
> > From 672a5b2f00a095dd1afc3259eca3f14439323e2b Mon Sep 17 00:00:00 2001
> > From: Ryan Sundberg <ryan@arctype.co>
> > Date: Wed, 28 Jul 2021 20:43:14 -0700
> > Subject: [PATCH] gnu: rocksdb: set TEST_TMPDIR for faster test i/o.
> >
> > The rocksdb test can take an egregious amount of time on a spinning HDD.
> > This will inherit guixbuild's /tmp mount for the rocksdb testing
> > directory.
> >
> > * gnu/packages/databases.scm (rocksdb)[arguments]: set TEST_TMPDIR for
> > check phase
>
> Applied, thanks!
>
> Ludo’.
>
>
> --- End Message ---