bug#49978: closed (28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH])

[GNU bug Tracking System]

Your message dated Tue, 10 Aug 2021 17:11:42 +0200
with message-id <1DA84CE4-E882-4DF1-B2C3-674FDF1B5D78@acm.org>
and subject line Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection 
broken on macOS [PATCH]
has caused the debbugs.gnu.org bug report #49978,
regarding 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49978: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49978
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH] Date: Tue, 10 Aug 2021 14:54:43 +0200

The auto-detection of colourised grep fails on macOS (and presumably BSD in 
general) because grep --help exits with a nonzero status (while still printing 
a useful option summary).

We should just ignore the exit status. Anyone against the attached patch?

grep-highlight-matches-autodetect.diff
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#49978: 28.0.50; grep-highlight-matches auto-detection broken on macOS [PATCH]
>
>
>
>
> Date: 
>
> Tue, 10 Aug 2021 17:11:42 +0200
>
>
>
>
> 10 aug. 2021 kl. 15.57 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > I think just looking for "--color[[]?=" should go a long way towards
> > avoiding false positives.
>
> Right, pushed something like that. Thank you!
>
> > Btw, is this usage message translatable?  If so, perhaps we should
> > inject LC_ALL=C when running the probe?
>
> I don't think we need to bother -- even if the message is translated the 
> options themselves are not.
>
>
>
> --- End Message ---