eliot-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Eliot-dev] [Patch] QT: Remove moc files


From: Olivier Teuliere
Subject: Re: [Eliot-dev] [Patch] QT: Remove moc files
Date: Thu, 13 May 2010 00:20:10 +0200

Hello Julien,

Thanks for your interest in Eliot.
It is always nice to have feedback!

On Wed, May 12, 2010 at 9:09 PM, Julien Catalano
<address@hidden> wrote:
> My name is Julien, I am a French embedded system Engineer, living in
> the Rennes area, Britanny.

Welcome to this list.
It seems you have the perfect profile for porting Eliot to smart
phones! Would you be interested by the job? :-)

> So here is my patch: remove the moc files from the source file
> distribution, as they are generated by the Makefiles anyway, and
> remove on make distclean as well (don't know if I made this part
> correct though). It works well on my computer, and might be useful to
> others, so here I am.
>
> Let me know if you have questions or trouble with my patch.

You are absolutely right, these generated files should not be
distributed. However, the source package is automatically generated
(with make dist and/or make distcheck), so removing the files is not
enough, the fix must involve some automake magic...

I have just committed a change which should fix the problem for the
next release. Thanks for reporting!

Best regards,
-- 
Olivier



reply via email to

[Prev in Thread] Current Thread [Next in Thread]