Re: [Denemo-devel] Command generation mechanism

[Richard Shann]

Great - I tested this as a new user, getting your branch by git clone.
Your standalone generator is working perfectly - slightly too perfectly
inasmuch as the resulting commands.c is identical including the initial
comment at the top of the file which needs now to point to the new
generate_commands.c file :)
We should aim to integrate your work as often as we can, so I suggest a
merge of your branch (to the current commit
62b71f3180a07cf91d4916588a014db13125ab46) now. Are you happy (& able) to
do this?

Richard


On Mon, 2013-05-06 at 11:42 +0200, Éloi Rivard wrote:
> This is pushed on eloi branch.
> Yep I use color-gcc for debugging but I forgot to reset gcc instead,
> this is fixed.
> 
> 
> 
> 2013/5/6 Richard Shann <address@hidden>
>         On Sun, 2013-05-05 at 20:42 +0200, Éloi Rivard wrote:
>         >
>         >
>         >
>         > See attached patch. utils/generate_commands creates the very
>         same code
>         > than launching denemo with -DGENERATE_SOURCE_CODE
>         > I indented some code in keyboard.c so some line have been
>         changed but
>         > the behavior is the same. I also fixed some unused variable
>         warnings.
>         
>         
>         This looks excellent - good work! I don't want to be acting as
>         a brake
>         on your development - I will get stressed out if I think
>         someone is
>         waiting for me to do something. So I think it will be good if
>         you bring
>         the branch eloi that Jeremiah created for you in git
>         up-to-date using
>         git merge (or whatever it is called) and commit your changes
>         there (I am
>         presuming Jeremiah has given you write permission).
>         I have a separate user account which I can use to build from
>         that branch
>         in a clean environment and test there.
>         This would be making proper use of git, rather than the
>         old-fashioned
>         patch methods...
>         
>          One thing I noticed in your code is something called
>         color-gcc, which I
>         guess is some colorized version of gcc? - I don't have that,
>         and we
>         wouldn't want to introduce more dependencies without a good
>         reason...
>         But that is the sort of wrinkle easily sorted out once the
>         code is in
>         git.
>         
>         Richard
>         
>         
> 
> 
> 
> -- 
> Éloi Rivard - address@hidden
>         
> « On perd plus à être indécis qu'à se tromper. »
>