Re: [PATCH] tests: fix FP in ls/stat-free-color.sh

[Bernhard Voelker]

On 4/21/21 3:32 PM, Pádraig Brady wrote:
> On 20/04/2021 23:15, Bernhard Voelker wrote:
>> This FP was seen on latest openSUSE - logfile attached.
>> The patch fixes it.  Okay to push?
> 
> Jim also noticed that on Fedora 34.
> 
> Oh so it's stating stdout.
> Could you change the "1" in your commit summary to STDOUT_FILENO
> as that makes the system behavior change more apparent to me at least.

done.

> Also the test is now relaxed a bit as it's no longer really checking regular 
> files.
> Could you instead try changing the first ls in the test
> to `ls -a` to ensure something is output?

Well, in the case ls would do an extra stat on each file in the test directory
(which we actually want to test that this is not the case), then ls would do so
for the 'regf' file and the new file.  So we'd see the test failing as well.
But adding -a for the reference invocation is also good.

Updated patch attached.  OK?

Thanks & have a nice day,
Berny

0001-tests-fix-FP-in-ls-stat-free-color.sh.patch
Description: Text Data