[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: fix FP in ls/stat-free-color.sh
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH] tests: fix FP in ls/stat-free-color.sh |
|
Date: |
Wed, 21 Apr 2021 14:32:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 |
On 20/04/2021 23:15, Bernhard Voelker wrote:
This FP was seen on latest openSUSE - logfile attached.
The patch fixes it. Okay to push?
Jim also noticed that on Fedora 34.
Oh so it's stating stdout.
Could you change the "1" in your commit summary to STDOUT_FILENO
as that makes the system behavior change more apparent to me at least.
Also the test is now relaxed a bit as it's no longer really checking regular
files.
Could you instead try changing the first ls in the test
to `ls -a` to ensure something is output?
cheers,
Pádraig