[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: classpath ./ChangeLog java/util/AbstractMap.jav...

From: Eric Blake
Subject: Re: classpath ./ChangeLog java/util/AbstractMap.jav...
Date: Wed, 20 Feb 2002 17:23:51 -0700

> >Log message:
> >       2002-02-20  Eric Blake  <address@hidden>
> >
> >       * java/util/ Delete; top-level classes in
> >       java.util should be public.
> >
> Not that I disagree with the patch, but what is your rationale for this?
> Suns implementation seems to have lots of non-public top-level classes.

But we're better than Sun, right? :)

Isn't the point of the* tree to hold the implementation and
helper classes not publicly specified?  I think it is a lot cleaner to
have, where possible, only the public classes as top-level ones in the
java.* namespace.  And so, with BasicMapEntry, my choice was to move it
to (and make everything in the class public, which could
be a nightmare if someone used reflection to modify it), or to move it
to be an inner class.  And besides, since Map.Entry is a nested class,
it makes sense to have AbstractMap.BasicMapEntry be one as well.

This signature intentionally left boring.

Eric Blake             address@hidden
  BYU student, free software programmer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]