Re: [cp-patches] Patch: use StringBuilder for reading/writing property files

[Mark Wielaard]

Hi Anthony,

On Thu, 2005-10-20 at 22:18 -0700, Anthony Green wrote:
> On Wed, 2005-10-19 at 14:53 -0700, Anthony Green wrote:
> > On Wed, 2005-10-19 at 12:49 -0700, David Daney wrote:
> > > You also might want to look at comment #1 of:
> > > 
> > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21869
> > 
> > Thanks for the pointer.  I think a non-copying unsynchronized
> > StringBuffer clearly makes the most sense.  I'll demonstrate the
> > improvement with gcj before my next patch.
> 
> I patched the FC rawhide GCC to use gnu.gcj.runtime.StringBuffer in
> java.util.Properties, and wrote a little program to read the locale
> property files from GNU Classpath.   Reading the property files was
> about 10% faster.
> 
> Here's oprofile output from before and after.  Note how _Jv_MonitorEnter
> and _Jv_MonitorExit migrate down the list.

Interesting. What was the total running time before/after this patch?
Could you post your test program?

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part