Re: [cp-patches] Patch: use StringBuilder for reading/writing property files

[David Daney]

Anthony Green wrote:
> Synchronization often shows up near the very top of gcj-compiled
> benchmarks.  It turns out that, for benchmarks I've run, ~50% of the
> synchronization calls come from reading property files with
> StringBuffer.  This should all go away if we use StringBuilder instead.

Have you actually profiled it with and without the change?  Not that 
this should be requisite for the patch, but it would be interesting to know.

Also since StringBuilder requires making a copy of the underlying char[] 
when converting to String, I would be interested to know how much extra 
time is consumed in allocations and coping of the buffer.

You also might want to look at comment #1 of:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21869



David Daney.