Re: [cp-patches] Re: RFC: Don't call protected addURL() method from URLClassLoader constructors

[Mark Wielaard]

Hi,

On Thu, 2005-10-20 at 11:11 -0600, Tom Tromey wrote:
> In a case like this the issue is that someone modifying the code won't
> know what application to test.  I sometimes add comments about
> particular applications, e.g. see the note about Eclipse in
> ResourceBundle.  I don't think there's much wrong with this practice.
> 
> In this particular case I'd like to see a comment mentioning jboss,

Added:
2005-10-22  Mark Wielaard  <address@hidden>

    * java/net/URLClassloader.java (addURLs): Add comment about jboss.

Cheers,

Mark

--- java/net/URLClassLoader.java        19 Oct 2005 23:11:10 -0000
1.41
+++ java/net/URLClassLoader.java        22 Oct 2005 09:34:02 -0000
@@ -758,6 +758,7 @@
    * store.  Called from the the constructors. Should not call to the
    * protected addURL() method since that can be overridden and
    * subclasses are not yet in a good state at this point.
+   * jboss 4.0.3 for example depends on this.
    *
    * @param newUrls the locations to add
    */

signature.asc
Description: This is a digitally signed message part