Re: [cp-patches] Re: RFC: Don't call protected addURL() method from URLClassLoader constructors

[Mark Wielaard]

On Wed, 2005-10-19 at 18:09 +0100, Andrew Haley wrote:
> Mark Wielaard writes:
>  > On Wed, 2005-10-19 at 17:36 +0100, Andrew Haley wrote:
>  > > You really shouldn't consider committing a patch like this without
>  > > adding comments.  After all, what is to stop someone changing it back?
>  > 
>  > Testing of know good applications.
> 
> Yeah, right.  :-)

Yeah, yeah... :) I know that it doesn't beat having real comments for
code. But I really do try running real known good applications before we
make any release to check that nothing is broken. And that does really
catch lots of issues that got introduced by accident. I do assume that
as soon as Jonas is fully packaged it will be one of the things we build
and regression tests against in the near future for example.

>  > But I see your point. Does the attached work for you?
> 
> Seems to pass basic smoke tests.  The Online Store demo works OK.

Thanks for checking!

Committed,

Mark

signature.asc
Description: This is a digitally signed message part