Re: [cp-patches] javax.swing.undo cleanup

[Roman Kennke]

Hi Micheal,

> > -public class CannotRedoException
> > -  extends RuntimeException
> > +public class CannotRedoException extends RuntimeException
> >  {
> 
> The old version is according to our formatting rules. The new version is
> not.

Well, last time I asked about that on IRC I was told (by tromey AFAIR)
that the new version is correct.

> 
> >    /**
> >     * Constructs a new instance of a <code>CannotRedoException</code>.
> >     */
> >    public CannotRedoException()
> >    {
> > +    super();
> >    }
> 
> You know that this is implicit and not needed. We try to avoid implicit stuff.

Yeah, I had the choice between calling super() and adding a comment.
Calling super() seemed more natural to me. If it's agreed that super();
should be avoided, then I'll replace it with a comment instead.

Comments?
/Roman

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil