Re: [cp-patches] javax.swing.undo cleanup

[Michael Koch]

On Wed, Oct 19, 2005 at 03:07:22PM +0000, Roman Kennke wrote:
> This adds super() calls to 2 previously empty constructors.
> 
> 2005-10-19  Roman Kennke  <address@hidden>
> 
>         * javax/swing/undo/CannotRedoException.java
>         * javax/swing/undo/CannotUndoException.java
>         Put super() call in empty constructors.
> 
> /Roman

> Index: javax/swing/undo/CannotRedoException.java
> ===================================================================
> RCS file: 
> /cvsroot/classpath/classpath/javax/swing/undo/CannotRedoException.java,v
> retrieving revision 1.3
> diff -u -r1.3 CannotRedoException.java
> --- javax/swing/undo/CannotRedoException.java 2 Jul 2005 20:32:52 -0000       
> 1.3
> +++ javax/swing/undo/CannotRedoException.java 19 Oct 2005 15:04:53 -0000
> @@ -44,13 +44,13 @@
>   * @author Andrew Selkirk (address@hidden)
>   * @author Sascha Brawer (address@hidden)
>   */
> -public class CannotRedoException
> -  extends RuntimeException
> +public class CannotRedoException extends RuntimeException
>  {

The old version is according to our formatting rules. The new version is
not.

>    /**
>     * Constructs a new instance of a <code>CannotRedoException</code>.
>     */
>    public CannotRedoException()
>    {
> +    super();
>    }

You know that this is implicit and not needed. We try to avoid implicit stuff.

>  }
> Index: javax/swing/undo/CannotUndoException.java
> ===================================================================
> RCS file: 
> /cvsroot/classpath/classpath/javax/swing/undo/CannotUndoException.java,v
> retrieving revision 1.3
> diff -u -r1.3 CannotUndoException.java
> --- javax/swing/undo/CannotUndoException.java 2 Jul 2005 20:32:52 -0000       
> 1.3
> +++ javax/swing/undo/CannotUndoException.java 19 Oct 2005 15:04:53 -0000
> @@ -53,5 +53,6 @@
>     */
>    public CannotUndoException()
>    {
> +    super();
>    }
>  }

Same here.


Cheers,
Michael
-- 
Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html

Join the community at http://planet.classpath.org/