classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches]: L&F fix


From: Lillian Angel
Subject: Re: [cp-patches]: L&F fix
Date: Thu, 22 Sep 2005 13:18:06 -0400

On Thu, 2005-09-22 at 18:38 +0200, Roman Kennke wrote:
> Hi Lillian,
> 
> you have committed the following:
> 
> -      "Tree.textBackground", new ColorUIResource(new Color(255, 255,
> 255)),
> -      "Tree.textForeground", new ColorUIResource(Color.black),
> +      "Tree.textBackground", new ColorUIResource(new Color(192, 192,
> 192)),
> +      "Tree.textForeground", new ColorUIResource(new Color(0, 0, 0)),
> 
> IMO writing new ColorUIResource(Color.BLACK) is slightly more efficient
> than new ColorUIResource(new Color(0, 0, 0)).
> 
> Also, have you seen that there is a testcase for
> BasicLookAndFeel.initComponentDefaults(). If these values are not
> already in this testcase, please add them.

No problem.
I sent the patch to mauve-discuss. I do not have commit access yet.

Lillian





reply via email to

[Prev in Thread] Current Thread [Next in Thread]