classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches]: L&F fix


From: Roman Kennke
Subject: Re: [cp-patches]: L&F fix
Date: Thu, 22 Sep 2005 19:23:29 +0200

Hi Lillian,

> >-      "Table.background", getWindowBackground(),
> >-      "Table.focusCellBackground", getWindowBackground(),
> >-      "Table.focusCellForeground", getControlTextColor(),
> >-      "Table.foreground", getControlTextColor(),
> >-      "Table.focusCellHighlightBorder", getControlShadow(),
> >-      "Table.focusCellBackground", getWindowBackground(),
> >-      "Table.gridColor", getControlDarkShadow(),
> >+      
> >+      "Table.background", new ColorUIResource(204, 204, 204),
> >+      "Table.focusCellBackground", new ColorUIResource(255, 255, 255),
> >+      "Table.focusCellForeground", new ColorUIResource(0, 0, 0),
> >+      "Table.foreground", new ColorUIResource(0, 0, 0),
> >+      "Table.focusCellHighlightBorder", new ColorUIResource(153, 153, 204),
> >+      "Table.gridColor", new ColorUIResource(153, 153, 153),
> >+      "Table.selectionBackground", new ColorUIResource(204, 204, 255),
> >+      "Table.selectionForeground", new ColorUIResource(0, 0, 0),
> >
> >  
> >
> Hi Lillian,
> 
> I don't think this will work if someone has a non-default theme 
> installed for the MetalLookAndFeel.  Roman has updated the Mauve test 
> for MetalLookAndFeel.getDefaults() to check for this, so you might want 
> to run your changes through Mauve to verify.

Oh yeah, this is certainly wrong. Lillian, if you see different values
in the JDK this might come from using a non-1.5 JDK which uses the
DefaultTheme. I have checked in the OceanTheme and made it the default
like in the JDK1.5. This leads to different color scheme but still
passes my mauve test. Please revert this patch.

/Roman

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


reply via email to

[Prev in Thread] Current Thread [Next in Thread]