Re: [cp-patches] FYI: Component.isDisplayable fixlet and Window method removal

[Roman Kennke]

Am Donnerstag, den 15.09.2005, 13:42 -0400 schrieb Thomas Fitzsimmons:
> On Thu, 2005-09-15 at 12:50 -0400, Anthony Balkissoon wrote:
> > Component.isDisplayable should return true if peer != null.  Window no
> > longer needs to override this method (and it doesn't, according to the
> > API), so I removed the method from Window.java.  Patch attached.
> 
> Window overrides isDisplayable specifically because
> Window.isDisplayable's return value should *not* depend on its parents
> displayability.

Sorry, maybe I misunderstand something here, but are there Windows that
have a non-null parent?

Also, wouldn't it be sufficent to check if a component has a peer? The
API docs are a little bit confusing, but that is what it sounds to me. 

Ok, the effect of Tony's patch is exactly that, that a component is
displayable if the top-level component has a peer. I think Tony is right
here. But as always, I would recommend writing testcases to clear up the
situation (I really have become a fan of mauve).

/Roman

signature.asc
Description: This is a digitally signed message part