Re: [cp-patches] [RFC] ProgressMonitor implemented

[Roman Kennke]

Am Donnerstag, den 15.09.2005, 20:09 +0200 schrieb Robert Schuster:
> Hi,
> this patch implements the ProgressMonitor. I'll send a demo application to the
> associated bug report[0].

Looks ok to me. Haven't tested it yet though. Will do this soon. But the
implementation looks quite straightforward to me and most of the work is
done in JOptionPane and JProgressBar and bugs will more likeley pop up
there and not in ProgressMonitor.

There are some slight formatting problems in there:

if (bla)
{
  // bla
}

is usually formatted like

if (bla)
  {
    // bla
  }

But that's it.

I wonder if the class ProgressMonitorInputStream is somehow required by
ProgressMonitor? Or is this optional? Or the other way round. Whatever,
it would be nice to also have this implemented, since this is also 100%
stub atm. It also looks quite simple.

/Roman

signature.asc
Description: This is a digitally signed message part