[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] Patch: fix || expressions in jdwp code
From: |
Anthony Green |
Subject: |
Re: [cp-patches] Patch: fix || expressions in jdwp code |
Date: |
Thu, 15 Sep 2005 07:29:33 -0700 |
On Thu, 2005-09-15 at 15:58 +0200, Mark Wielaard wrote:
> Hi Anthony,
>
> On Wed, 2005-09-14 at 17:49 -0700, Anthony Green wrote:
> > {
> > - if (tid == null | tid.getReference().get () == null)
> > + if (tid == null || tid.getReference().get () == null)
> > throw new InvalidThreadException (tid.getId ());
>
> Note that in this case, and the case below you still will get a
> NullPointerException, not an InvalidThreadException if tid == null.
Oh, right. I guess we can just get rid of the tid == null test all
together.
Keith - maybe I'll just leave this for you to figure out the right
solution.
Thanks,
AG