Re: [cp-patches] patch for approval fixes bug #23006

[Anthony Balkissoon]

Done.
--Tony

On Thu, 2005-09-15 at 00:22 +0200, Roman Kennke wrote:
> Am Mittwoch, den 14.09.2005, 13:17 -0400 schrieb Anthony Balkissoon:
> > This patch was inappropriate.  The appropriate changes should be made in
> > JTextArea.  I've attached the new patch and will check it in and the
> > Mauve test case.
> > 
> > 2005-09-14  Anthony Balkissoon  <address@hidden>
> > 
> >         * javax/swing/JTextArea.java:
> >         (append): After non-empty append, invalidate.
> >         (setRows): If number of rows changes, invalidate.
> >         (setColumns): If number of columns changes, invalidate.
> 
> In Swing you should not use invalidate(). Generally you should use
> revalidate() in Swing. This also calls invalidate() and triggers the
> Swing RepaintManager to do it's job and validate and repaint the
> component soon. Could you change that?
>       
> /Roman
>