classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Revert glibtoolize patch for Darwin


From: Andreas Tobler
Subject: Re: [cp-patches] Revert glibtoolize patch for Darwin
Date: Sat, 03 Sep 2005 21:26:51 +0200
User-agent: Mozilla Thunderbird 1.0.5 (Macintosh/20050711)

Hi Mark,

thanks for the corrections.

Mark Wielaard wrote:

        echo "You must have libtool 1.5 installed to compile $PROJECT."
        echo "Install the appropriate package for your distribution,"
        echo "or get the source tarball at http://ftp.gnu.org/gnu/libtool/";
+       echo "For Darwin you need the latest stable to support Frameworks"
+       echo "linking. Also, you have to point ACLOCAL_FLAGS to this"
+       echo "libtool/share/aclocal."


I am not a Darwin person, but are you sure that "the latest stable to
support Frameworks linking" is clear enough?

You mean in terms of version numbering or in terms of explaining all the details behind ?

In terms of version I propose this.

Yes, it is tested on darwin ppc.

Thanks for review!
Andreas

2005-09-03  Andreas Tobler  <address@hidden>

        * autogen.sh: Document libtool version needed for Darwin.
        (LIBTOOLIZE): Don't special case Darwin, always use libtoolize.
Index: autogen.sh
===================================================================
RCS file: /cvsroot/classpath/classpath/autogen.sh,v
retrieving revision 1.12
diff -u -r1.12 autogen.sh
--- autogen.sh  1 May 2005 21:16:31 -0000       1.12
+++ autogen.sh  3 Sep 2005 19:24:45 -0000
@@ -12,16 +12,9 @@
 
 DIE=0
 
-case `uname -s` in
-Darwin)
-       LIBTOOLIZE=glibtoolize
-       ;;
-*)
-       LIBTOOLIZE=libtoolize
-       ;;
-esac
+LIBTOOLIZE=libtoolize
 
-have_libtool=true
+have_libtool=false
 if ${LIBTOOLIZE} --version < /dev/null > /dev/null 2>&1 ; then
        libtool_version=`${LIBTOOLIZE} --version | sed 
's/^[^0-9]*\([0-9.][0-9.]*\).*/\1/'`
        case $libtool_version in
@@ -35,6 +28,9 @@
        echo "You must have libtool 1.5 installed to compile $PROJECT."
        echo "Install the appropriate package for your distribution,"
        echo "or get the source tarball at http://ftp.gnu.org/gnu/libtool/";
+       echo "For Darwin you need the latest stable (1.5.18) to support"
+       echo "Frameworks linking. Also, you have to point ACLOCAL_FLAGS"
+       echo "to this libtool/share/aclocal."
        DIE=1
 fi
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]