Re: [cp-patches] Revert glibtoolize patch for Darwin

[Mark Wielaard]

Hi Andreas,

On Fri, 2005-09-02 at 23:36 +0200, Andreas Tobler wrote:
> my first contribution as cp member :)

Welcome! Welcome!

> I'd like to revert a patch I introduced in spring this year.
> 
> Ok for head ?

Yes please. Assuming you tested this on a darwin box of course.

But let me nitpick about the ChangeLog entry.
(That is just as an traditional welcome, it won't happen again, grin) 

> 2005-09-02  Andreas Tobler  <address@hidden>
> 
>       * autogen.sh: Revert glibtoolize patch from:
>       2005-05-01  Andreas Tobler  <address@hidden>
>       With the upcoming qt-peers we need to link against Frameworks on
>       Darwin. The installed libtool on Darwin does not support the machinery.

Just document what you change, the why really should be a comment in the
code if it is relevant:

2005-09-02  Andreas Tobler  <address@hidden>

        * autogen.sh: Document libtool version needed for Darwin.
        (LIBTOOLIZE): Don't special case Darwin, always use libtoolize.

>          echo "You must have libtool 1.5 installed to compile $PROJECT."
>          echo "Install the appropriate package for your distribution,"
>          echo "or get the source tarball at http://ftp.gnu.org/gnu/libtool/";
> +       echo "For Darwin you need the latest stable to support Frameworks"
> +       echo "linking. Also, you have to point ACLOCAL_FLAGS to this"
> +       echo "libtool/share/aclocal."

I am not a Darwin person, but are you sure that "the latest stable to
support Frameworks linking" is clear enough?

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part