Re: [cp-patches] [patch] document BufferCapabilities

[Thomas Fitzsimmons]

On Thu, 2005-05-05 at 10:28 +0200, Mark Wielaard wrote:
> Hi,
> 
> On Wed, 2005-05-04 at 18:17 -0400, Thomas Fitzsimmons wrote:
> > 2005-05-04  Thomas Fitzsimmons  <address@hidden>
> > 
> >     * java/awt/BufferCapabilities.java: Document.
> 
> This broke the GNU Classpath build:
> 
>    /**
>     * Creates a buffer capabilities object.
>     *
> -   * @exception IllegalArgumentException If frontCaps or backCaps are null.
> +   * @param frontCaps front buffer capabilities descriptor
> +   * @param backCaps back buffer capabilities descriptor
> +   * @param flipContents the results of a flip operation or null if
> +   * flipping is not supported
> +   *
> +   * @exception IllegalArgumentException if frontCaps or backCaps is
> +   * null
>     */
> -  public BufferCapabilities(ImageCapabilities front, ImageCapabilities back,
> -                            FlipContents flip)
> +  public BufferCapabilities(ImageCapabilities frontCaps,
> +                           ImageCapabilities backCaps,
> +                            FlipContents flipContents)
> 
> But now the arguments and the code don't match so we get errors like:
> 
> ../java/awt/BufferCapabilities.java: In class `java.awt.BufferCapabilities':
> ../java/awt/BufferCapabilities.java: In constructor 
> `(java.awt.ImageCapabilities,java.awt.ImageCapabilities,java.awt.BufferCapabilities$FlipContents)':
> ../java/awt/BufferCapabilities.java:147: error: variable 'front' may not have 
> been initialized.
>        if (front ==  null || back == null)
>           ^
> ../java/awt/BufferCapabilities.java:147: error: variable 'back' may not have 
> been initialized.
>        if (front ==  null || back == null)
>           ^
> ../java/awt/BufferCapabilities.java:151: error: variable 'flip' may not have 
> been initialized.
>        this.flip = flip;
>    ^
> 3 errors
> 
> Obvious fix checked into GNU Classpath CVS:
> 

Damn, sorry.  Thanks for fixing this.

Tom