Re: [cp-patches] [generics] Patch: FYI: ProcessBuilder

[Tom Tromey]

>>>>> "Robert" == Robert Schuster <address@hidden> writes:

>> -  for (i = 0; i < 3; i++)
>> +  for (i = 0; i < pipe_count; i++)
>> {
>> -      /* Mode is WRITE (2) for in and READ (1) for out and err. */
>> const int fd = fds[i][i == 0];
>> -      const int mode = (i == 0) ? 2 : 1;
>> +      const int mode = ((i == 0)
>> +                    ? gnu_java_nio_channels_FileChannelImpl_WRITE
>> +                    : gnu_java_nio_channels_FileChannelImpl_READ);
>> jclass sclazz;
>> jmethodID smethod;

Robert> I think the above declarations and definitions have to moved to the
Robert> beginning of the function.

This code is fine since the declarations are at the start of a block.
(I didn't change anything except the constants here.)

Tom