Re: [cp-patches] [Patch] java.net.InetAddress

[Dalibor Topic]

Jeroen Frijters wrote:
> Michael Koch wrote:
>
> > On Wednesday 13 October 2004 13:19, Jeroen Frijters wrote:
> >
> > > Michael Koch wrote:
> > >
> > > > I wrote the attached patch to add the missing method
> > > > java.net.InetAddress.getCanonicalHostName().
> > >
> > > I haven't tried the patch yet, but the following looks wrong:
> > >
> > > +    // Try to find the FDQN now
> > > +    InetAddress address = new Inet4Address(getAddress(), null);
> > > +    return address.getHostName();
> > >
> > > Shouldn't that be:
> > >
> > > +    // Try to find the FDQN now
> > > +    InetAddress address = InetAddress.getByAddress(getAddress());
> > > +    return address.getHostName();
> >
> > In this case: it doesnt matter, the result is the same. If 
> > hostname is null getHostName() does a lookup. Calling getByAddress
> > is IMHO too much not needed work like getting all hostnames for an
> > address instead of only one.
>
>
> I was thinking about IPv6 addresses, wouldn't they go wrong with your
> code?

Code that assumes Inet4 addresses for localhost would fail on an IPv6 
only host, afaict.

cheers,
dalibor topic