classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [cp-patches] [Patch] java.net.InetAddress


From: Jeroen Frijters
Subject: RE: [cp-patches] [Patch] java.net.InetAddress
Date: Wed, 13 Oct 2004 13:19:18 +0200

Michael Koch wrote:
> I wrote the attached patch to add the missing method
> java.net.InetAddress.getCanonicalHostName().

I haven't tried the patch yet, but the following looks wrong:

+    // Try to find the FDQN now
+    InetAddress address = new Inet4Address(getAddress(), null);
+    return address.getHostName();

Shouldn't that be:

+    // Try to find the FDQN now
+    InetAddress address = InetAddress.getByAddress(getAddress());
+    return address.getHostName();

Regards,
Jeroen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]