[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-users] valgrind - more details

From: Christian Kellermann
Subject: Re: [Chicken-users] valgrind - more details
Date: Wed, 5 Oct 2011 23:22:51 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Dear Jörg,

* Jörg F. Wittenberger <address@hidden> [111005 22:29]:
> While I've been following this valgrind hint I ran into some
> code in C_a_i_string_to_number ... as expectable this code
> is kinda complicated since the problem it solves is just below
> the level where one would consider to write a real parser and
> at the same time beyond complexity you want to handle ad hoc.

Thanks for your analysis!

I am interested in this patch, but I would like to know a couple
of things:

1. What is this diff against? I could not apply it to master or
   4.7.0 or even This would be helpful information to
   get started. It is a few lines off and through all this confusion
   maybe you are missing something. I don't know...

2. Did you run a make check against this patch? make check has some
   number syntax checks in it and I believe changing the while loop
   below to an if statement should trigger those. If not it could
   be a bug (in the test and the patch). Peter confirmed that crazy
   stuff like #x#e123 is valid number syntax.

So could I ask you about some of your precious minutes to

* get a git checkout, the command is git clone 
* diff against master, (make changes run git diff > more-changes.diff )
* run make check and
* send the patch to address@hidden ?

This would aid me and others in reviewing and understanding the
changes (well in this case your intentions are clear, but the while
loop is still subtle). Also it would ease the process of trying
your proposals for everyone else too.

Thanks again for taking your time for this!


Who can (make) the muddy water (clear)? Let it be still, and it will
gradually become clear. Who can secure the condition of rest? Let
movement go on, and the condition of rest will gradually arise.
 -- Lao Tse. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]