[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] Prevent excessive major gcs by preserving a decent amoun
|
From: |
Peter Bex |
|
Subject: |
Re: [PATCH 0/1] Prevent excessive major gcs by preserving a decent amount of unused heap |
|
Date: |
Mon, 13 Apr 2020 17:10:55 +0200 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Apr 13, 2020 at 02:13:24PM +0200, Peter Bex wrote:
> On Mon, Apr 13, 2020 at 11:51:41AM +1200, Evan Hanson wrote:
> > On 2020-04-12 19:11, Peter Bex wrote:
> > > What's the deal with the FAIL for knucleotide in both patched versions?
> >
> > Oh, that's because knucleotide needs srfi-69 and I didn't install it for
> > the testing builds.
>
> Ah, okay, so nothing to worry about then :)
>
> I've applied this patch and also added a NEWS entry (as this is a
> noteworthy change) Thanks to you both!
Sorry, I forgot to run the tests. This patch breaks the finalizer tests
because a reallocating GC doesn't run finalizers. The tests try to force
finalizers to run by forcing a major GC with (gc #t), which triggers a
reallocation due to the new code's watermark being reached.
I tried to fix this, but was unable to make it work, so I reverted the
commit for now.
Cheers,
Peter
signature.asc
Description: PGP signature