[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of re

From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of replaced variables
Date: Wed, 3 Jul 2019 14:05:21 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Wed, Jul 03, 2019 at 02:54:24PM +0300, megane wrote:
> Regarding the capturing, the capture test is still there:
> >      (when (and value (not global))
> >        (when (eq? '##core#variable (node-class value))
> > -        (let* ((name (first (node-parameters value)))
> > -               (nrefs (db-get db name 'references)) )
> > +        (let ((name (first (node-parameters value))) )
> >            (when (and (not captured)
>                           ^^^^^^^^^^^^^^
>                           Here.
> I got the impression you wanted to remove this.

You're right, good catch!  That was an oversight on my part, I only
removed the captured check of the other variable.  I hope this makes
things faster in more cases.  I can make and test a new patch, but don't
know when I'll get around to it.  Possibly in the weekend.


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]